Skip to content

test: share checked PNG fixture decoding - #1157

Merged
andiwand merged 2 commits into
mainfrom
review/139-png-test-helpers
Oct 6, 2026
Merged

andiwand merged 2 commits into
mainfrom
review/139-png-test-helpers

Conversation

@andiwand

@andiwand andiwand commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

🤖 Generated with Claude Code

Three PNG readers duplicated chunk parsing in the PNG and PDF image tests. Their nonfatal assertions could continue into out-of-bounds reads when encoder output was malformed.

Share one checked reader for RGB, RGBA and indexed PNG output, including CRC and pixel-data validation. Move the existing encoder-only RGBA round trip to the PNG suite and retain the image assertions without adding overlapping tests.

Validation: all 24 PngUtil.* and PdfImage.* tests pass.

@andiwand
andiwand force-pushed the review/138-pdf-recovery-precedence branch from 2f50fb5 to 16e474c Compare October 6, 2026 18:19
Base automatically changed from review/138-pdf-recovery-precedence to main October 6, 2026 18:20
@andiwand
andiwand force-pushed the review/139-png-test-helpers branch from d17013e to 9a676e4 Compare October 6, 2026 18:21
@andiwand
andiwand merged commit f8b0c87 into main Oct 6, 2026
23 of 25 checks passed
@andiwand
andiwand deleted the review/139-png-test-helpers branch October 6, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant