Repository navigation
test: compile public C++20 headers independently - #1167
Merged
Merged
Conversation
andiwand
force-pushed
the
review/148-pdf-image-sampling
branch
from
October 6, 2026 19:14
cf34d88 to
71ca5a9
Compare
andiwand
force-pushed
the
review/149-public-header-coverage
branch
from
October 6, 2026 19:16
34b573a to
46a9893
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
The C++20 public-header check included 15 headers in one translation unit, allowing earlier includes to hide missing dependencies and leaving three headers unchecked. Compile every installed public header independently, automatically picking up additions and respecting the HTTP option. Disable unity compilation for this target so it cannot combine the checks again.
This replaces the aggregate test; it adds no runtime test cases. All 18 headers pass with HTTP enabled. All 17 installed headers pass with HTTP disabled and global unity builds enabled. A temporary new header lacking its required include fails the target as expected, then the clean target passes after removal.