Repository navigation
build: align CMake requirements and generated asset storage - #1169
Merged
Merged
Conversation
andiwand
force-pushed
the
review/150-pdf-image-integer-bounds
branch
from
October 6, 2026 19:25
2ba538d to
1e9542c
Compare
andiwand
force-pushed
the
review/151-cmake-build-contract
branch
from
October 6, 2026 19:28
5b20032 to
7f0098d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Declare CMake 3.20, the first version that recognizes the existing CXX_STANDARD 23 requirement, instead of advertising 3.15. Document the build and consumer language requirements.
Generate frontend asset storage as explicitly sized std::array<char, N>, preserving the byte-literal representation that avoids MSVC's string-literal size limit. String views use data()/size().
Validation: library/test builds and library plus four CLI analysis builds pass; 23 targeted HTML/media tests pass. All 23 generated assets match their source bytes with signed and unsigned char. An all-256-byte fixture and generated assets compile for Android, WebAssembly and iOS. No new permanent test cases for this representation-only change; CMake 3.20 itself was not available for runtime testing.