Repository navigation
fix(pdf): preserve Identity font character widths - #1174
Merged
Merged
Conversation
andiwand
force-pushed
the
review/155-annotation-state-ownership
branch
from
October 6, 2026 19:35
a68684c to
36f101f
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
andiwand
force-pushed
the
review/156-pdf-identity-code-width
branch
from
October 6, 2026 19:40
86ea6f2 to
e3a5800
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
A multilingual PDF declares Identity-H but has a conflicting ToUnicode codespace. Complete codespace matching introduced in #1123 split its two-byte glyph IDs into bytes, corrupting text and spacing. Identity-H/V now retain their mandated two-byte width for both glyph iteration and text extraction (ISO 32000-1 9.7.5.2). Simple-font zero-padding and mixed-width CMaps keep their existing behavior.
One inline regression covers both identity encodings and trailing partial codes; it fails on the parent. All 463 targeted PDF tests, including the 50-document corpus, pass. The affected document's combined view and corrupted pages match the reference again: 19 of 21 outputs match, with the remaining two differing only in pre-existing 0.01-point path rounding. Full local clang-tidy, WebAssembly tests, and all four Android ABI rebuilds pass.