Repository navigation
refactor: share whole-token integer parsing - #1176
Merged
Merged
Conversation
andiwand
force-pushed
the
review/157-utf-api-boundary
branch
from
October 6, 2026 19:56
ecfc159 to
3581f3b
Compare
andiwand
force-pushed
the
review/158-integer-parsing-util
branch
from
October 6, 2026 20:05
fa8b878 to
a02580e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Integer parsers repeated whole-token checks, overflow handling and leading
+stripping. Addutil::number::parse_integer<T>with explicit radix andallow_plusoptions, and use it across PDF, OOXML, ODF, Type 1 fonts, Markdown entities and number formats. Format-specific whitespace, bounds and failure handling stay at the call sites, so a lenient caller keeps its fallback; prefix parsers remain separate.Adds four utility tests and one assertion to the existing PDF unsigned-integer test, reusing the format suites for integration coverage.
Validation: 290 targeted tests passed, plus the added PDF sign assertion; native build, clang-format 18 and clang-tidy passed (existing analyzer advisories remain). Object compilation passed with emsdk 3.1.73, NDK 28.1 and the iOS 15 deployment target.