Skip to content

fix(html): stop a cell spill at a covered cell, and advance the output pins - #1177

Merged
andiwand merged 2 commits into
mainfrom
fix/spill-covered-cells
Oct 6, 2026
Merged

andiwand merged 2 commits into
mainfrom
fix/spill-covered-cells

Conversation

@andiwand

@andiwand andiwand commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

main fails the reference comparison, because the references were behind. While I checked the differences, I found one regression, and this PR fixes it.

Fix. The cell index of an ods holds no covered cell, so a lookup at a covered position gives a blank cell. Since #1008, the spill scan therefore let text run over the merged cell from a row above, for example (KWH) over KWH Meter in style-various-2.ods. The sheet loop now records, per column, the row where a span from above ends, and the scan stops at a covered column, as LibreOffice does. A new test covers it, and the test fails without the fix.

References. Pinned to public 78e3081 and private 2e4e8ef, regenerated with this fix. I checked each kind of change against the source files:

🤖 Generated with Claude Code

andiwand and others added 2 commits October 6, 2026 10:55
The cell index of an ods holds no covered cell, so a lookup there gives
a blank cell. The spill scan then let text run over the merged cell
from a row above, for example '(KWH)' over 'KWH Meter' in
style-various-2.ods. The sheet loop now records, per column, the row
where a span from above ends, and the scan stops at a covered column,
as LibreOffice does.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
…nges

The references take the output of #1079 to #1126 and of the spill fix
before this commit.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
@andiwand
andiwand merged commit 2db4acc into main Oct 6, 2026
29 checks passed
@andiwand
andiwand deleted the fix/spill-covered-cells branch October 6, 2026 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant