Repository navigation
fix(html): stop a cell spill at a covered cell, and advance the output pins - #1177
Merged
Merged
Conversation
The cell index of an ods holds no covered cell, so a lookup there gives a blank cell. The spill scan then let text run over the merged cell from a row above, for example '(KWH)' over 'KWH Meter' in style-various-2.ods. The sheet loop now records, per column, the row where a span from above ends, and the scan stops at a covered column, as LibreOffice does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
…nges The references take the output of #1079 to #1126 and of the spill fix before this commit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gb1fLafqqzehpqPuU6uBfn
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mainfails the reference comparison, because the references were behind. While I checked the differences, I found one regression, and this PR fixes it.Fix. The cell index of an ods holds no covered cell, so a lookup at a covered position gives a blank cell. Since #1008, the spill scan therefore let text run over the merged cell from a row above, for example
(KWH)overKWH Meterinstyle-various-2.ods. The sheet loop now records, per column, the row where a span from above ends, and the scan stops at a covered column, as LibreOffice does. A new test covers it, and the test fails without the fix.References. Pinned to public
78e3081and private2e4e8ef, regenerated with this fix. I checked each kind of change against the source files:transparentno longer inherits a colour (fix: clear inherited ODF backgrounds and borders #1089):Senza nome 1.ods,efficiency-big-1.ods.1E-6) is read. The shown text does not change.document.js,editing.js,sheet-editing.js,spreadsheet.jsandtext.js(fix: address post-v7.4.0 spreadsheet review findings #1018, fix: preserve Unicode pairs during browser deletion #1094).🤖 Generated with Claude Code