Repository navigation
fix: preserve files during filesystem copies - #1178
Merged
Merged
Conversation
andiwand
marked this pull request as ready for review
October 6, 2026 20:11
andiwand
added a commit
that referenced
this pull request
Oct 6, 2026
Both output repositories carry the pdf-annotation.js from #1171 and #1173. A full run on 078390a matched every reference page byte for byte; only that script changed. #1178, merged since, changes how a file copy is written, not its bytes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MxyTMutqSUJRGfxA8CyzMc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 Generated with Claude Code
Copying a file onto itself truncated it before reading; a failed source read also destroyed an existing destination. Route filesystem copies through the existing atomic writer, closing the source before replacement. This also reuses checked flush and cleanup behavior.
Validation: filesystem regressions failed before the fix and pass afterward; Filesystem.* and VirtualFilesystem.* pass in the integrated stack. Atomic replacement changes inode identity and requires write access to the destination directory.
Stack: based on
main. Review against this base; merge the stack bottom-up.