ci: compare the output with htmlcmp 2.4.0 - #915
Merged
Merged
Conversation
2.4.0 settles the page before it shoots it - `document.fonts.ready` and two frames rather than `readyState` alone - and renders a mismatch again before reporting it. Both are for the `test (macos-26)` job, which failed on five pull requests in a row naming a different set of files each time, three of them changing javascript that cannot alter a pdf view. 2.3.0 comes with it: it modernised the report and cropped the empty tail of a shot before the diff. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0149gFxhkvKTBQidz6brU8Vt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test (macos-26)failed on five pull requests in a row — 907, 908, 909, 910, 911 — each naming a different set of files. 908 and 909 changed only spreadsheet and document javascript, which cannot alter a pdf view by a pixel, so the difference was in the rendering rather than in the files.Two things in
compare-htmlallowed that, both fixed in opendocument-app/compare-html#19 and released as v2.4.0:screenshotwaited forreadyStateonly, which does not cover a web font: the load event fires while the face is still arriving and the text is laid out again once it lands. It now waits fordocument.fonts.readyand two frames.compare_htmlnow renders a mismatch again before reporting it. A real difference is in the markup and comes back every time, so nothing is hidden, and the matching files — almost all of them — are still rendered once.2.3.0 comes along with the bump: it modernised the report and crops the empty tail of a tall shot before diffing.
Checked
With 2.4.0 installed from PyPI, the exact invocation this workflow uses:
style-various-1.pdfagainst itself0style-various-1.pdfagainstempty.pdf1So a match still passes and a real difference still fails.
No
CHANGELOG.mdentry: this is CI, which the changelog's own preamble leaves to the generated list.