Skip to content

Take core 7.2.0, which is what the free highlighter needs - #669

Merged
andiwand merged 1 commit into
mainfrom
core-7-2
Sep 20, 2026
Merged

andiwand merged 1 commit into
mainfrom
core-7-2

Conversation

@andiwand

@andiwand andiwand commented Sep 20, 2026 •

Copy link
Copy Markdown
Member

#668 moved the edition gate from the mode to the tool and left the highlighter working in every build. In a pdf that works today. In a text document it is a format call under editing scope paragraph, and core 7.1.0 refuses every one of those - so lite has been offering pro for the one tool it is meant to give away. 7.2.0 takes a format that starts and ends in one paragraph and refuses it over two, which is what the scope is about.

The release carries the rest of what the rebuilt editing UI was written against:

  • a pdf mark covers the glyphs it marks rather than the selection layer's em box, and an underline and a squiggle hang below the text rather than running through it
  • odr.editing.setSheetOptions({editOnClick}), which editing-bridge.js states, because a WebView answers the pointer as a mouse on an emulator and the sheet's tap-to-edit never fired there
  • a selection in a pdf view no longer paints the invisible text layer, and keeps its highlight background
  • fitting the width states a minimum-scale where the content is more than four screens wide, so an A0 page zooms out to fit instead of scrolling sideways at the browser's floor of 0.25

CLAUDE.md records that last one under Fitting the page to the screen, since it is a rule someone could undo: the floor is the page's to state, and viewportContent would take the whole question over and give a spreadsheet a fit it does not want.

Checked

Not by CI yet - the artifact is still on its way to maven central, so the build here will fail to resolve app.opendocument:odr-core-android:7.2.0 until it lands. Re-run then.

What is checked is the code: the app was built against these very commits as a local AAR and run on a Pixel 9 Pro and a Pixel 6 Pro emulator - the marks, the selection, the sheet's single tap and the wide page all behave, and the app's own suites pass (97 instrumented tests on pro, 97 on lite, unit tests, lint, three flavors).

SupportedFormatsTest is the one to watch when CI runs: 7.2.0's changelog names no new format, so the manifest's filters should still agree with the core's table, and that test says so either way.

The edition gate leaves the highlighter working in every build, and in a
text document that is a `format` call under editing scope `paragraph`.
Core 7.1.0 refuses every one of those, so until now lite offered pro for
the one tool it was meant to give away. 7.2.0 takes a format that starts
and ends in one paragraph and refuses it over two, which is what the
scope is about.

The release carries the rest of what the rebuilt editing UI was written
against:

- a pdf mark covers the glyphs it marks rather than the selection layer's
  em box, and an underline and a squiggle hang below the text rather than
  running through it
- `odr.editing.setSheetOptions({editOnClick})`, which the bridge states,
  because a WebView answers the pointer as a mouse on an emulator and the
  sheet's tap-to-edit never fired there
- a selection in a pdf view no longer paints the invisible layer, and
  keeps its highlight background
- fitting the width states a `minimum-scale` where the content is more
  than four screens wide, so an A0 page zooms out to fit

Checked by building the app against this core's commits and running it on
a Pixel 9 Pro and a Pixel 6 Pro emulator: the marks, the selection, the
sheet's single tap and the wide page all behave, and the app's own suites
pass - 97 instrumented tests on pro.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FJJdfqpnVCKBNHXjAVxSou
@andiwand
andiwand merged commit 9ac90a0 into main Sep 20, 2026
7 of 9 checks passed
@andiwand
andiwand deleted the core-7-2 branch September 20, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant