Hold the status bar off the window's top, not the content view's - #674
Merged
Merged
Conversation
The banner moved into the decor's stack, above the content view and the bar an action mode raises. The inset padding stayed on `main_root`, inside the content view, so the status bar was held off the wrong thing: the banner drew behind the clock, and the padding below it left a dead strip the tools strip and the document rode down on. The padding now sits on the stack that holds all three, so the status bar is held off once, for everything in the window. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJJdfqpnVCKBNHXjAVxSou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#672 moved the banner into the decor's stack, so it sits above the content view and above the bar an action mode raises. The inset padding stayed behind on
main_root, which is inside the content view.So the status bar was held off the wrong thing. On a Pixel 9 Pro the window read:
The padding now goes on the stack that holds the banner, the action mode's bar and the content, so the status bar is held off once for all three:
Confirmed on a Pixel 9 Pro, on the landing screen and in a pdf's markup mode.