Draw the highlight and ink marks flat, like the marks beside them - #675
Merged
Merged
Conversation
Two of the icons in the strip were pen drawings among four flat text marks. The highlight becomes the stroke rather than the tool - a band across a line of text - and the ink loses the pen over it, keeping humps wider and higher than ic_format_squiggly's wave, which stands for an underline. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FJJdfqpnVCKBNHXjAVxSou
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two icons in the strip were pen drawings among four flat text marks, and read as odd next to them.
ic_marker.xmlgoes,ic_highlight.xmltakes its place, and the document's highlight tool follows it.ic_format_squiggly's wave, so the two do not read alike - that one stands for an underline, this one for drawing.Built and looked at on a Pixel 9 Pro, in a pdf's markup strip.