Repository navigation
Conversation
The certificate web view's "About" section rendered `company_about_url` unconditionally, but that name is only put in the context when an About page URL is configured: by an enabled CertificateHtmlViewConfiguration, the site configuration's `urls`, or the marketing URLs. Since the marketing link fallback to the LMS's own pages was removed, a default install has none of these, so `valid.html` raised `NameError: Undefined` and every learner's "View my certificate" link answered 500. Leave the "Learn more" link out when the URL is undefined, the same guard the certificate footer already uses for the Terms of Service and Privacy Policy links. Closes #39222 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The certificate web view's "About" section rendered
company_about_urlunconditionally, but that name is only put in the context when an About page URL is configured: by an enabled CertificateHtmlViewConfiguration, the site configuration'surls, or the marketing URLs. Since the marketing link fallback to the LMS's own pages was removed, a default install has none of these, sovalid.htmlraisedNameError: Undefinedand every learner's "View my certificate" link answered 500.Leave the "Learn more" link out when the URL is undefined, the same guard the certificate footer already uses for the Terms of Service and Privacy Policy links.
Closes #39222