fix msys2 with apothecary packaged opencv4 - #8566
Merged
Merged
Conversation
The msys2 CI job mixed a pinned system OpenCV 4.13 (via pkg-config) with the Apothecary-bundled libopencv_world.a, whose objects reference cv::g_Saturate8u / cv::g_8x32fTab as DLL imports with no DLL present, failing the allAddonsExample link with undefined symbols. Use exactly one OpenCV on msys2: the Apothecary-built OpenCV 4 static libraries bundled under addons/ofxOpenCv/libs/opencv, mirroring how the Android and Emscripten sections already work. - addons/ofxOpenCv/addon_config.mk: msys2 section lists the bundled static archives explicitly instead of pkg-config opencv4, and no longer excludes the bundled headers/libs - scripts/msys2/install_dependencies.sh: remove the pinned pacman OpenCV install, the 5.x fallback, and the addon_config.mk pkg-config rewrite Requires an Apothecary msys2 opencv4 package whose libopencv_world.a actually defines the core data tables (the 2026-09-28 package's world archive only carries .refptr imports for them and cannot link).
The Apothecary package lays its static archives out per architecture (lib/msys2/x86_64, lib/msys2/aarch64, ...). % is expanded to a glob by the makefile addon parser (and understood by the Project Generator), so match whichever arch directory the installed package ships instead of hardcoding x86_64.
MSYS2's zlib package ships libz.a / libz.dll.a, not libzlib, so -lzlib failed the allAddonsExample link with "cannot find -lzlib". libzlib.a only exists in the emscripten bundle.
danoli3
force-pushed
the
msys2-bundled-opencv
branch
from
September 30, 2026 14:49
b1a6314 to
d01d439
Compare
pacman aborts the whole setup-msys2 transaction when one mirror is slow
("Operation too slow ... download library error"), failing the job
before anything builds. Retry the setup once (without the package cache),
and stop one flaky msystem leg from cancelling the others.
Also refresh the stale comment: ofxOpenCv now links the Apothecary-built
OpenCV 4 bundle, not a pinned pacman package.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link the Apothecary-built OpenCV 4 static libraries on msys2 instead of the pacman opencv package.
Requires an Apothecary msys2 opencv4 package whose libopencv_world.a defines the core data tables.