Conversation
…26 on Windows when installed
danoli3
force-pushed
the
vs2026-platform-support
branch
from
September 11, 2026 12:04
715a8c3 to
24bb3e9
Compare
danoli3
marked this pull request as draft
September 12, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vs2019/vs2026were essentially inert as PG platform targets: several hardcodedplatform == "vs"exact-match checks scattered through the C++ backend (most severelyofAddon::checkCorrectPlatform()) silently dropped an entire addon's Windows-specificaddon_config.mkdirectives for these targets.vs/vs2019/vs2026as equivalent MSVC/Visual Studio targets where appropriate, while keeping their distinct toolsets (v143/v142/v145) intact.vswhere.exeand pre-selects it over thevs(2022) default when installed; platform dropdown now explicitly lists Visual Studio 2019/2022/2026 as separate entries (each locks a distinct MSVC toolset, so this is deliberate, not redundant).Test plan
commandLinebinary and generated real test projects forvs2019/vs2026/vstargets with an addon that has Windows-specificaddon_config.mkdirectives; confirmed the directives are now applied (previously silently dropped) forvs2019/vs2026.vswhere.exe-based VS2026 detection logic against the existinggetVisualStudioPath()implementation.