Repository navigation
test(config): Pin reload and overlay behaviour - #1421
Merged
Merged
Conversation
|
Bencher Report| Project | keystone |
| Branch | claude/project-thread-bzh5uv |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| Command_Serde/apply/remove | 📈 view plot 🚷 view threshold | 125,500.00 ns(-50.44%)Baseline: 253,203.02 ns | 1,345,629.76 ns (9.33%) |
| Command_Serde/apply/set | 📈 view plot 🚷 view threshold | 133,110.00 ns(-56.04%)Baseline: 302,773.14 ns | 1,846,887.48 ns (7.21%) |
| Command_Serde/pack/delete | 📈 view plot 🚷 view threshold | 138.83 ns(+17.75%)Baseline: 117.90 ns | 167.56 ns (82.86%) |
| Command_Serde/pack/delete_index | 📈 view plot 🚷 view threshold | 119.22 ns(+13.48%)Baseline: 105.06 ns | 145.09 ns (82.17%) |
| Command_Serde/pack/set | 📈 view plot 🚷 view threshold | 217.72 ns(+12.90%)Baseline: 192.85 ns | 271.96 ns (80.06%) |
| Command_Serde/pack/set_index | 📈 view plot 🚷 view threshold | 119.59 ns(+13.84%)Baseline: 105.05 ns | 145.13 ns (82.40%) |
| Command_Serde/unpack/delete | 📈 view plot 🚷 view threshold | 169.32 ns(+2.63%)Baseline: 164.98 ns | 256.74 ns (65.95%) |
| Command_Serde/unpack/delete_index | 📈 view plot 🚷 view threshold | 151.39 ns(+8.83%)Baseline: 139.11 ns | 212.34 ns (71.30%) |
| Command_Serde/unpack/set | 📈 view plot 🚷 view threshold | 259.86 ns(+4.34%)Baseline: 249.06 ns | 378.24 ns (68.70%) |
| Command_Serde/unpack/set_index | 📈 view plot 🚷 view threshold | 143.08 ns(+3.67%)Baseline: 138.01 ns | 209.33 ns (68.35%) |
| Payload_encryption/pack/remove_cmd | 📈 view plot 🚷 view threshold | 129.67 ns(+17.41%)Baseline: 110.44 ns | 160.99 ns (80.54%) |
| Payload_encryption/pack/set_cmd | 📈 view plot 🚷 view threshold | 216.86 ns(+8.51%)Baseline: 199.86 ns | 297.64 ns (72.86%) |
| Payload_encryption/unpack/remove_cmd | 📈 view plot 🚷 view threshold | 166.78 ns(-2.34%)Baseline: 170.77 ns | 270.04 ns (61.76%) |
| Payload_encryption/unpack/set_cmd | 📈 view plot 🚷 view threshold | 280.46 ns(+8.96%)Baseline: 257.39 ns | 393.51 ns (71.27%) |
| Raft_1Node_Latency/prefix/1node | 📈 view plot 🚷 view threshold | 2,469,300.00 ns(-20.71%)Baseline: 3,114,351.72 ns | 7,516,383.84 ns (32.85%) |
| Raft_1Node_Latency/read/1node | 📈 view plot 🚷 view threshold | 42,390.00 ns(+15.54%)Baseline: 36,688.75 ns | 52,932.52 ns (80.08%) |
| Raft_1Node_Latency/remove/1node | 📈 view plot 🚷 view threshold | 353,010.00 ns(-33.30%)Baseline: 529,257.81 ns | 1,794,916.31 ns (19.67%) |
| Raft_1Node_Latency/write/1node | 📈 view plot 🚷 view threshold | 375,290.00 ns(-35.84%)Baseline: 584,885.00 ns | 2,646,038.42 ns (14.18%) |
| build_snapshot/default | 📈 view plot 🚷 view threshold | 2,167.30 ns(-98.57%)Baseline: 151,380.75 ns | 996,327.02 ns (0.22%) |
| fernet token/project | 📈 view plot 🚷 view threshold | 1,477.20 ns(+9.08%)Baseline: 1,354.22 ns | 1,842.92 ns (80.16%) |
| get_data_keyspace | 📈 view plot 🚷 view threshold | 0.32 ns(+3.91%)Baseline: 0.30 ns | 0.39 ns (81.80%) |
| get_db | 📈 view plot 🚷 view threshold | 0.31 ns(+3.61%)Baseline: 0.30 ns | 0.39 ns (81.56%) |
| get_fernet_token_timestamp/project | 📈 view plot 🚷 view threshold | 144.55 ns(+7.04%)Baseline: 135.04 ns | 180.33 ns (80.16%) |
| get_keyspace | 📈 view plot 🚷 view threshold | 4.21 ns(-32.95%)Baseline: 6.27 ns | 14.14 ns (29.75%) |
gtema
marked this pull request as ready for review
October 6, 2026 06:16
|
🧪 Tempest Identity Compatibility Results (advisory, non-blocking) rust Failed test IDs |
|
🦢 Load Test Results Goose Attack ReportPlan Overview
Request Metrics
Response Time Metrics
Status Code Metrics
Transaction Metrics
Scenario Metrics
Error Metrics
|
Add characterization tests ahead of extracting the config engine (ADR 0039, #1416): overlay precedence (env, site-vars, file), last-known-good retention with no notification on an invalid reload, convergence after an event burst, and idempotent shutdown. Signed-off-by: Artem Goncharov <artem.goncharov@gmail.com>
gtema
force-pushed
the
claude/project-thread-bzh5uv
branch
from
October 6, 2026 07:11
03e10af to
0e02b3f
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 6, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: the config reload machinery (watch loop, last-known-good, overlay precedence) had tests for single behaviours, but nothing pinned the cases that the engine extraction in ADR 0039 (#1416) could silently break.
After: four new tests in
crates/configpin that behaviour before any code moves (PR 1 of the implementation plan):OS_*env over the site-vars file over the main fileshutdown()on a watched manager is idempotent and stops applying edits