Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 40m 42s |
b548ba1 to
17d742e
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 11m 28s |
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
17d742e to
dc4c005
Compare
When enabled, migrate running VMs in creation order and wait for each migration before continuing. This prevents overlapping migrations during post-adoption updates. Signed-off-by: Samuel Rac <srac@redhat.com>
dc4c005 to
ec90d10
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 58m 54s |
|
recheck |
| '((.status == "ACTIVE") or (.status == "PAUSED")) and | ||
| (.["OS-EXT-SRV-ATTR:host"] != $source_host)' |
There was a problem hiding this comment.
AI raised a concern over this check using the full 1 hour timeout (720 retries at 5 second intervals) if a migration fails and stays active on the pre-migration host. I'm not super familiar with the process here, but is this a valid concern? Could an early failure get stuck waiting for a full hour before failing?
There was a problem hiding this comment.
Hi Micheal, I also thought about this issue, however, I haven't found an easy way to check it at the moment. So far, there were no issues with the timeout, but we can update it in the future if needed, based on production logs.
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 5m 24s |
Wait for each VM evacuation to finish before starting the next one. Asynchronous VM migration can cause issues when VMs have overlapping host constraints.