[update] Allow selecting NodeSets for compute reboot

[srac0]

Allow callers to supply the NodeSets used by the reboot deployment. When unset, continue discovering every NodeSet in the namespace.

[qodo-code-review]

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pinikomarov for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• roles/update/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[michburk]

/retest-required

[michburk]

One question, otherwise lgtm.

[michburk]

I noticed that your testproject has to construct cifmw_update_node_sets.stdout as a newline-delimited string, just for it to be parsed back into a list here in the cifmw. Do you think it would make sense to move this stdout normalizing to a task above when no manual cifmw_update_node_sets is provided. Then the job definition could pass os_update_compute_nodesets directly, rather than fabricating an oc stdout-shaped value.

[srac0]

Hi Michael, thanks for raising it. I've just amended my patch :)

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/88faf6f7b51b4e5d9f04c506be1d65bb

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 55m 15s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 49s
✔️ podified-multinode-edpm-deployment-crc-centos-10 SUCCESS in 1h 27m 08s
❌ cifmw-crc-podified-edpm-baremetal FAILURE in 27m 33s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 28m 40s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 38s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 8h 12m 56s
✔️ cifmw-crc-podified-edpm-baremetal-bootc SUCCESS in 1h 30m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 10m 11s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 37s
❌ cifmw-molecule-update FAILURE in 6m 01s

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/508e9dbc007d4d55aaad8e9af1d5f610

❌ openstack-k8s-operators-content-provider FAILURE in 6m 22s
⚠️ podified-multinode-edpm-deployment-crc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc-centos-10 SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ cifmw-crc-podified-edpm-baremetal-minor-update SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
✔️ cifmw-pod-zuul-files SUCCESS in 4m 35s
❌ openstack-k8s-operators-content-provider-bootc NODE_FAILURE Node(set) request 100-0000218835 failed in 0s
⚠️ cifmw-crc-podified-edpm-baremetal-bootc SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider-bootc
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 28s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 31s
✔️ cifmw-molecule-update SUCCESS in 6m 55s