dataplane: default to neutron-ovn instead of neutron-metadata

[karelyatin]

The standalone ovn-metadata-agent is deprecated in favor of the unified ovn-agent's metadata extension, which is now enabled by default (openstack-k8s-operators/edpm-ansible). Switch the default OpenStackDataPlaneNodeSet services list, samples, and docs from neutron-metadata to neutron-ovn accordingly.

The nova-metadata-neutron-config secret carries nova_metadata_host and metadata_proxy_shared_secret, both needed by the metadata extension. Make it required for neutron-ovn, matching neutron-metadata, so reconciliation correctly waits on it instead of silently running without metadata config.

Depends-On: openstack-k8s-operators/edpm-ansible#1289
Depends-On: openstack-k8s-operators/ci-framework#4218
Related-Issue: #OSPRH-37892

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: karelyatin
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

OpenStackControlPlane CRD Size Report

Metric	Value
CRD JSON size	338593 bytes (331KB)
Base branch size	338593 bytes
Change	+0.00%
Status	yellow — growing

Threshold reference

Color	Range	Meaning
🟢 green	< 300KB	Comfortable
🟡 yellow	300–400KB	Growing
🟠 orange	400–750KB	Concerning
🔴 red	> 750KB	Approaching 1.5MB etcd limit (cut in half to allow space for update)

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 6535a6c9-8acf-4f99-8a5c-c173b1a6559e

📥 Commits

Reviewing files that changed from the base of the PR and between 0996400 and b4f7c46.

📒 Files selected for processing (15)

• api/bases/dataplane.openstack.org_openstackdataplanenodesets.yaml
• api/dataplane/v1beta1/openstackdataplanenodeset_types.go
• bindata/crds/crds.yaml
• config/crd/bases/dataplane.openstack.org_openstackdataplanenodesets.yaml
• config/samples/dataplane/bgp/values.yaml
• config/samples/dataplane/bgp_ovn_cluster/values.yaml
• config/samples/dataplane/ceph/values.yaml
• config/samples/dataplane/ovs_dpdk/values.yaml
• config/samples/dataplane_v1beta1_openstackdataplanenodeset.yaml
• config/services/dataplane_v1beta1_openstackdataplaneservice_neutron_ovn.yaml
• docs/assemblies/con_data-plane-services.adoc
• docs/assemblies/proc_creating-a-custom-service.adoc
• docs/assemblies/ref_example-OpenStackDataPlaneNodeSet-CR-for-bare-metal-nodes.adoc
• docs/assemblies/ref_example-OpenStackDataPlaneNodeSet-CR-for-preprovisioned-nodes.adoc
• test/functional/dataplane/openstackdataplanenodeset_controller_test.go

💤 Files with no reviewable changes (2)

• config/samples/dataplane/ovs_dpdk/values.yaml
• config/services/dataplane_v1beta1_openstackdataplaneservice_neutron_ovn.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Changes
  • Default dataplane configurations now use neutron-ovn instead of neutron-metadata. The OVN agent’s metadata extension provides metadata services to Compute nodes.
  • Standalone neutron-metadata is marked as deprecated and superseded by the OVN extension.
  • The neutron-ovn service now requires the Nova metadata configuration secret.

Walkthrough

The default dataplane service list now uses neutron-ovn instead of neutron-metadata. The OVN service's metadata secret reference is no longer optional. Samples, functional test expectations, and documentation are updated; the OVS-DPDK sample removes neutron-metadata.

Changes

Dataplane neutron service selection

Layer / File(s)	Summary
Default service and OVN configuration api/dataplane/v1beta1/openstackdataplanenodeset_types.go, api/bases/..., config/crd/bases/..., bindata/crds/crds.yaml, config/services/dataplane_v1beta1_openstackdataplaneservice_neutron_ovn.yaml, test/functional/dataplane/openstackdataplanenodeset_controller_test.go	The NodeSet default service list and functional test expectations replace neutron-metadata with neutron-ovn. The OVN service configuration no longer marks the nova-metadata-neutron-config secret reference as optional.
Samples and documentation config/samples/dataplane/*/values.yaml, config/samples/dataplane_v1beta1_openstackdataplanenodeset.yaml, docs/assemblies/con_data-plane-services.adoc, docs/assemblies/proc_creating-a-custom-service.adoc, docs/assemblies/ref_example-OpenStackDataPlaneNodeSet-CR-for-*	Samples and NodeSet examples update their service lists; the OVS-DPDK sample removes neutron-metadata. Documentation describes the OVN metadata extension and marks standalone neutron-metadata as deprecated.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Feature

Suggested reviewers: rabi

Merge Risk: ⚪ Minimal · up to b4f7c

The default dataplane service list now uses neutron-ovn instead of neutron-metadata, and docs and samples match. No concrete merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: making neutron-ovn the default instead of neutron-metadata.
Description check	✅ Passed	The description directly explains the service replacement, the required secret change, and the related dependencies.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[centosinfra-prod-github-app]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/afb22129a6ca44b591e37540460f7c37

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 52s
❌ openstack-operator-content-provider-cs10 FAILURE in 5m 14s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 28m 26s
⚠️ openstack-operator-crc-podified-edpm-baremetal SKIPPED Skipped due to failed job openstack-operator-content-provider-cs10
✔️ podified-multinode-edpm-deployment-crc-antelope SUCCESS in 1h 30m 24s
❌ adoption-standalone-to-crc-ceph-provider FAILURE in 2h 08m 22s (non-voting)
✔️ openstack-operator-tempest-multinode SUCCESS in 1h 44m 23s
✔️ openstack-operator-docs-preview SUCCESS in 3m 13s
❌ openstack-operator-edpm-baremetal-minor-update FAILURE in 2h 17m 33s (non-voting)