Repository navigation
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
c699185 to
2e5d7a0
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 49m 42s |
|
github.com/openstack-k8s-operators/openstack-operator/pull/2070/ is merged so i think we may get rid of the watcher-operator-validation-master job too. Also, i see we are skipping some tests that were added to the tempest plugin that we may run in the master job: as: Although these were also missing in the old job, may we use this PR to also enable them? |
There was a problem hiding this comment.
I think we should make them voting now too.
2e5d7a0 to
902d0d1
Compare
|
Zuul encountered a syntax error while parsing its expected str for dictionary value @ data['github-check']['jobs'][3]['watcher-s2i-content-provider'] The problem appears in the "openstack-k8s-operators/watcher-operator" project stanza: project: in "openstack-k8s-operators/watcher-operator/.zuul.yaml@main", line 379 |
902d0d1 to
a2de966
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 13s |
|
recheck |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 5m 27s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 44m 25s |
|
recheck |
1 similar comment
|
recheck |
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/ci-framework#4217 is needed. |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 56m 05s |
|
recheck |
a2de966 to
127b2c4
Compare
|
Zuul encountered a syntax error while parsing its found duplicate anchor; first occurrence |
127b2c4 to
6a76808
Compare
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 14m 58s |
amoralej
left a comment
amoralej
left a comment
There was a problem hiding this comment.
I see the watcher-s2i-tempest now runs all the tests. Just missing removing the old one, and I'd suggest reorganizing it into the template.
| - name: openstack-operator | ||
| src: "{{ ansible_user_dir }}/src/github.com/openstack-k8s-operators/openstack-operator" | ||
| image_base: watcher | ||
| - watcher-operator-validation-master: |
There was a problem hiding this comment.
The idea was to get rid of this job as the new s2i one has the same coverage but without s2i parent job which allows to do depends-on, etc..
Actually, i'd suggest reorganizing the new jobs for the github-check in this project-template.
6a76808 to
9cff272
Compare
|
|
||
| - job: | ||
| name: watcher-operator-validation-master | ||
| name: periodic-watcher-operator-validation-master |
There was a problem hiding this comment.
FTR, this job is not executed since https://review.rdoproject.org/r/c/config/+/59056
However we can not remove it while the template is still defined (both the template and this job should be removed).
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 40m 14s |
9cff272 to
627182b
Compare
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 6m 14s |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 56m 24s |
18ba4b7 to
d484cec
Compare
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 37s |
The old CentOS 9 EDPM validation jobs are superseded by the s2i-based job, which provides the same test coverage but uses a regular EDPM parent instead of the s2i parent, allowing depends-on across repos. .zuul.yaml: - Drop the CentOS 9 base jobs and rename the CentOS Stream 10 ones to the canonical watcher-operator-base / watcher-operator-validation-base. - Remove the old CentOS 9 watcher-operator-validation-master (meta content) and periodic-watcher-operator-validation-master. - Rename watcher-s2i-tempest to watcher-operator-validation-master and add a matching periodic-watcher-operator-validation-master, both on CentOS Stream 10 consuming s2i-built images. - Consolidate the content-provider and validation jobs into the opendev-master-watcher-operator-pipeline github-check template. - Make the jobs voting. Enable the full tempest coverage on the NFS configuration: boot-from- volume, skipped action and delete/shelve action tests, and register the nfs/nfs-2 cinder volume backends during edpm prepare. Pin the nfs/nfs-2 cinder volume backends to the master s2i cinder-volume image via an explicit cinderVolumeImages entry in cifmw_set_containers_images (set_containers backends format). Otherwise the edpm_prepare role auto-generates those backends from the default registry/org/tag, which resolve to the antelope-centos9 cinder-volume image. That mismatches the master cinder api/scheduler/backup services and breaks AMQP exchange durability (cinder-scheduler_fanout), crash- looping cinder-volume and failing every volume test. Assisted-by: Claude Opus 4.8 <noreply@anthropic.com>
d484cec to
1117155
Compare
|
Build succeeded (check pipeline). ✔️ openstack-k8s-operators-content-provider SUCCESS in 5h 57m 57s |
This branch has not been deployed
2 participants
Consolidate watcher validation jobs on CentOS Stream 10 s2i images
What
This change replaces the old CentOS 9 EDPM validation jobs with the s2i-based job, which already provides the same tempest coverage. As suggested in review, it also reorganizes the jobs into the project template and keeps the familiar watcher-operator-validation-master naming instead of watcher-s2i-tempest.
.zuul.yaml
Test coverage
Notes