Adjust the scroll-margin-top for anchors on pages with the student nav. (hotfix of #3203) - #3205
Open
drgrice1 wants to merge 1 commit into
Open
Conversation
somiaj
approved these changes
Sep 9, 2026
…nav. This makes the `scroll-margin-top` setting for elements with an `id` attribute (used as anchors via a URL fragment) account for the height of the student/problem nav if it is present on the page. Basically, the value of the `--sticky-nav-height` css variable is always added to the `scroll-margin-top` for these elements. If the sticky student/problem nav is present on the page, then JavaScript sets the value of that css variable to the height of the sticky nav plus `1rem`. Thus when a URL fragment is used the id element is not obscured behind the sticky nav. One place where this is prominent is when viewing a problem in a test from either the set detail page for the test when editing a set version for a user, or from the manual problem grader when grading a problem in a test. @somiaj mentioned this in openwebwork#3202, and I have observed this for a while now. Note that @somiaj adds `outline: none` to these test div elements with an `id` which also improves the initial appearance when the page loads.
drgrice1
force-pushed
the
sticky-nav-scroll-margin-adjust-hotfix
branch
from
September 9, 2026 18:09
5f2489a to
372f31b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
scroll-margin-topsetting for elements with anidattribute (used as anchors via a URL fragment) account for the height of the student/problem nav if it is present on the page. Basically, the value of the--sticky-nav-heightcss variable is always added to thescroll-margin-topfor these elements. If the sticky student/problem nav is present on the page, then JavaScript sets the value of that css variable to the height of the sticky nav plus1rem. Thus when a URL fragment is used the id element is not obscured behind the sticky nav.One place where this is prominent is when viewing a problem in a test from either the set detail page for the test when editing a set version for a user, or from the manual problem grader when grading a problem in a test.
@somiaj mentioned this in #3202, and I have observed this for a while now. Note that @somiaj adds
outline: noneto these test div elements with anidwhich also improves the initial appearance when the page loads.