⚠ make spec.namespace optional in the experimental channel - #2929
nader-ziada wants to merge 2 commits into
Conversation
When spec.namespace is empty the applier stops passing WithSelfManagedInstallNamespace, so the renderer resolves the install namespace from bundle metadata and emits the Namespace object itself. This is gated on BoxcutterRuntime; with the gate off an empty spec.namespace is a terminal configuration error rather than a silent fallback. Signed-off-by: Nader Ziada <nziada@redhat.com>
On the experimental channel spec.namespace may now be omitted, in which case operator-controller resolves and creates a managed namespace from the bundle's metadata. Whether the field is set or omitted is locked at creation time: it cannot be added, removed, or changed afterwards. The standard channel keeps the existing required and immutable contract. Signed-off-by: Nader Ziada <nziada@redhat.com>
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/cc @joelanford @perdasilva pr #3 |
1 participant
Description
Makes ClusterExtension.spec.namespace optional in the experimental API to support system-managed install namespaces.
When omitted, the controller uses the bundle’s system-managed namespace instead of requiring callers to provide one.
Changes
Testing
Depends on #2926 for the runtime handling of an omitted namespace.
Reviewer Checklist