Repository navigation
validation: use corrected API deprecation validator - #7141
Open
sebrandon1 wants to merge 2 commits into
Open
sebrandon1 wants to merge 2 commits into
sebrandon1 wants to merge 2 commits into
Conversation
Signed-off-by: Brandon Palm <bpalm@redhat.com>
Keep all k8s.io modules on the same minor version as the api, apimachinery, and client-go dependencies raised by the API v0.43.0 update. Signed-off-by: Brandon Palm <bpalm@redhat.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Operator SDK to
operator-framework/apiv0.43.0, the first released API version containing the RBAC deprecation false-positive fix. The validator no longer warns for RBAC rules that name resources with supported API versions, while checks for deprecated manifest API versions and removed resources remain.Dependency scope
API v0.43.0 requires newer Kubernetes libraries, so this PR also:
k8s.iomodules (api,apimachinery,client-go,apiserver,component-base,cli-runtime,kubectl) to v0.35.4 so they stay on one minor version.controller-runtimefrom v0.21.0 to v0.23.3, which addsApplyto the client interface. The SDK test client now forwards it.//nolint:staticcheck), now that controller-runtime deprecatesGetEventRecorderFor.controller-toolsv0.18.0 andkubebuilder/v4v4.6.0 unchanged, to keep the scaffolding changes out of this PR.Validation
make test-unitgo vet ./...GOTOOLCHAIN=go1.26.3 make lint(0 issues)name=operatorhubv2,name=capabilities,name=categories, andsuite=operatorframework. Each one returned no warnings or errors.The GitHub Actions workflows (go, sanity, helm, deploy, integration, memcached-sample) still need maintainer approval before they can run.
Related PRs