Repository navigation
NO-ISSUE: Raise OSAC merge-queue timeout to 180m - #251
Merged
minmzzhang merged 2 commits intoOct 8, 2026
Merged
minmzzhang merged 2 commits into
minmzzhang merged 2 commits into
Conversation
Increase the OSAC ruleset response window to 180 minutes because full-install E2E checks can outlast the existing 120-minute limit. Assisted-by: OpenAI Codex <https://openai.com/codex> Signed-off-by: Min Zhang <minzhang@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 10 remain after this review. WalkthroughThe ChangesMerge Queue Timeout
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested labels: Merge Risk: ⚪ Minimal · up to The longer response window addresses the reported check duration without an identified merge-blocking issue. Normal validation remains appropriate. 🚥 Pre-merge checks | ✅ 11✅ Passed checks (11 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
minmzzhang
marked this pull request as ready for review
October 8, 2026 13:19
Move the timeout rationale outside the attribute block so tofu fmt preserves its alignment. Assisted-by: OpenAI Codex <https://openai.com/codex> Signed-off-by: Min Zhang <minzhang@redhat.com>
Contributor
|
/lgtm |
Contributor
|
/approve |
minmzzhang
enabled auto-merge (squash)
October 8, 2026 13:39
rccrdpccl
approved these changes
Oct 8, 2026
2 of 3 tasks
minmzzhang
added a commit
that referenced
this pull request
Oct 8, 2026
## Summary - Remove the duplicate `ibengal` entry from `members.csv` and `team-members/fulfillment-wg.csv`. - Unblock OpenTofu validation and the automatic apply of the 180-minute OSAC merge-queue timeout from #251. ## Context The post-merge apply fails `tofu validate` with duplicate object keys for `ibengal` and `fulfillment-wg-ibengal`. Since validation fails before `tofu apply`, the live ruleset remains at 120 minutes. This removes the repeated rows while preserving each existing membership. ## Jira N/A ## Test plan - [x] `pre-commit run --files members.csv team-members/fulfillment-wg.csv` - [x] `git diff --check` - [ ] `tofu validate` (not run locally; OpenTofu is unavailable in this environment) --- _This PR description was drafted with AI assistance ([create-pr](https://github.com/osac-project/osac-workspace/tree/main/skills/create-pr) v0.1.3). Review for accuracy._ Signed-off-by: Min Zhang <minzhang@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
On Oct 8, PR #1321's merge-group checks started around 09:24 UTC. The CaaS full-install check completed at 11:36 UTC, while the queue removed the entry at 11:25 UTC. The configured 120-minute response window expired before that required gate reported success. A 180-minute window gives about 49 minutes of headroom over the observed 131-minute run.
Validation
git diff --checkpassed.pre-commit run --all-files: all hooks passed excepttofu-fmt, which could not run because OpenTofu (tofu) is not installed locally. The repository's CI pre-commit workflow installs OpenTofu and runs this hook.Summary
repo_osac’s merge-queuecheck_response_timeout_minutesfrom 120 to 180 minutes.repo_osac_test_infraremains 120 minutes.git diff --checkpassed. The author also reports that allpre-commithooks passed excepttofu-fmt, which could not run because OpenTofu was not installed locally. The repository’s CI workflow reportedly installs OpenTofu and runs that hook; no CI result is provided here.Risk classification
Risk label and classification criteria are unavailable. The supplied context does not include the labeling instructions or a stated applied label. A comparison with another risk label cannot be established.