Repository navigation
Try to avoid "...//state.txt" URLs for replication. - #320
Open
amandasaurus wants to merge 1 commit into
Open
amandasaurus wants to merge 1 commit into
amandasaurus wants to merge 1 commit into
Conversation
Previously, for a base URL of "example.com/area-updates/" the code would look for "example.com/area-updates//state.txt" etc. This change will make it request "example.com/area-updates/state.txt". It now doesn't “double slash”. This will ensure providers of OSM data updates (e.g. Geofabrik) will see consistent URLs regardless of small typing changes.
amandasaurus
force-pushed
the
repl-dont-double-slash
branch
from
October 5, 2026 13:25
9c83fb5 to
41267ea
Compare
lonvia
reviewed
Oct 12, 2026
lonvia
left a comment
lonvia
left a comment
Member
There was a problem hiding this comment.
Fine with me in general. Unfortunately, merging is currently stuck on rather exotic CI fails of the Windows builds, which I have yet no idea how to fix.
| # Try to avoid calling `example.com/area-updates//state.txt` | ||
| baseurl_wo_slash = self.baseurl | ||
| while baseurl_wo_slash[-1] == "/": | ||
| baseurl_wo_slash = baseurl_wo_slash[:-1] |
Member
There was a problem hiding this comment.
Probably better to do that in __init__ while assigning self.baseurl so it is only done once. (The variable could be overwritten later in theory but that would be unintended use, so safe to ignore.)
Also, you should use the endswith() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, for a base URL of
example.com/area-updates/the code would look forexample.com/area-updates//state.txt" etc. This change will make it requestexample.com/area-updates/state.txt`. It now doesn't “double slash”.This will ensure providers of OSM data updates (e.g. Geofabrik) will see consistent URLs regardless of small typing changes.
This change is inspired by Postel's Law: “be conservative in what you send, be liberal in what you accept”.