Skip to content

ci: Require an absolute delta before flagging a benchmark regression #10701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kokokoXUY wants to merge 1 commit into from
Closed

ci: Require an absolute delta before flagging a benchmark regression #10701

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions .github/workflows/ci-performance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,9 @@ jobs:
console.log('| Benchmark | Baseline | PR | Change | Status |');
console.log('|-----------|----------|----|---------| ------ |');

// Ignore relative changes below this absolute delta (milliseconds).
const ABSOLUTE_NOISE_FLOOR_MS = 2;

let hasRegression = false;
let hasImprovement = false;

Expand All @@ -214,14 +217,21 @@ jobs:
const change = ((prValue - baseValue) / baseValue * 100);
const changeStr = change > 0 ? \`+\${change.toFixed(1)}%\` : \`\${change.toFixed(1)}%\`;

// Benchmarks measured in fractions of a millisecond move by tens of
// percent on ordinary runner noise, so a relative threshold alone
// fails unrelated pull requests. Require the absolute change to
// clear a floor before the percentage decides the status.
const absoluteChange = prValue - baseValue;
const clearsNoiseFloor = Math.abs(absoluteChange) >= ABSOLUTE_NOISE_FLOOR_MS;

let status = '✅';
if (change > 50) {
if (change > 50 && clearsNoiseFloor) {
status = '❌ Much Slower';
hasRegression = true;
} else if (change > 25) {
} else if (change > 25 && clearsNoiseFloor) {
status = '⚠️ Slower';
hasRegression = true;
} else if (change < -25) {
} else if (change < -25 && clearsNoiseFloor) {
status = '🚀 Faster';
hasImprovement = true;
}
Expand Down