Repository navigation
fix: align the extension with Patchloom CLI 0.37.1 - #289
Merged
Merged
Conversation
Patchloom 0.37.1 returns format_failed when a formatter hits its 30 second deadline, and the write may already be on disk. Quick Actions and Batch Apply waited 30 seconds from process start, so Node killed the CLI before that error could return. They now wait 45 seconds. MCP inventory is still 66 tools and the core pack is still 12. Minimum CLI stays 0.3.0. Docs cover the 0.37.1 edit and containment fixes. Batch Apply says a formatter failure is restored with Undo. Verified with npm run check (479 tests, package ok) and a live probe of patchloom-v0.37.1. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the extension with Patchloom CLI 0.37.1. The recommended CLI is 0.37.1. The minimum stays 0.3.0. The MCP inventory is still 66 tools, and the core pack is still 12.
Quick Actions and Batch Apply now wait 45 seconds. The CLI format deadline is 30 seconds and starts after the write. The old 30 second process limit killed the CLI before
format_failedcould return. That error means the write may already be on disk. Undo restores it.Why
Patchloom 0.37.1 (
patchloom-v0.37.1) kills a formatter that closes stderr or leaves a background process holding it, and returnserror_kind: format_failed. A parent.patchloom.tomloutside git no longer supplies format commands. Containment checks several reads before opening the file. Short hunks are parse errors. Literal$in replacement text stays text.Verification
patchloom.exeat the archive root.format_failedonreplace --applywith[format] auto = trueleaves the file written and namespatchloom undo. The same failure onbatch --applydoes not roll the write back.npm run check: 479 tests passed, line coverage 92.87%,vsce packageok.Checklist
git commit -snpm run checkand it passes