Repository navigation
fix(what-changed): compare object composition refactors safely - #650
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #650 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 300 301 +1
Lines 38284 38373 +89
=========================================
+ Hits 38284 38373 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
daveshanley
marked this pull request as ready for review
October 6, 2026 13:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object schemas moved into an equivalent
oneOfor a wideranyOfcurrently produce false breaking property removals. Compare the preserved object branch through the existing schema comparator, while keeping added alternatives visible as non-breaking changes.Rebuilds #611 and retains its regression scenarios. The shortcut is limited to pure wrappers, explicit object/null types, and provably disjoint object-versus-null
oneOfbranches. Wrapper assertions, overlapping branches, dropped types, changed root enum/const values, and uncertain cases retain structural comparison. Null alternatives account for enum and const constraints.Validation: Linux and Windows full test suites, the Linux race suite, and CodeQL passed on
ccf29e001db1b5e7f0d291aa1a11b0835710d1e0. Codecov reports 100% patch and project coverage. PublicCompareDocumentsregressions cover the original blocking cases, real widening, null constraints, and structured enum narrowing. Independent correctness, de-slop, and final repair reviews are complete with no open findings.Risk: medium. This changes diff classification, with conservative fallback for unsupported shapes. No public API or dependency changes.