Skip to content

fix(what-changed): compare object composition refactors safely - #650

Merged
daveshanley merged 2 commits into
mainfrom
codex/schema-composition-wrap
Oct 6, 2026
Merged

daveshanley merged 2 commits into
mainfrom
codex/schema-composition-wrap

Conversation

@daveshanley

@daveshanley daveshanley commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Object schemas moved into an equivalent oneOf or a wider anyOf currently produce false breaking property removals. Compare the preserved object branch through the existing schema comparator, while keeping added alternatives visible as non-breaking changes.

Rebuilds #611 and retains its regression scenarios. The shortcut is limited to pure wrappers, explicit object/null types, and provably disjoint object-versus-null oneOf branches. Wrapper assertions, overlapping branches, dropped types, changed root enum/const values, and uncertain cases retain structural comparison. Null alternatives account for enum and const constraints.

Validation: Linux and Windows full test suites, the Linux race suite, and CodeQL passed on ccf29e001db1b5e7f0d291aa1a11b0835710d1e0. Codecov reports 100% patch and project coverage. Public CompareDocuments regressions cover the original blocking cases, real widening, null constraints, and structured enum narrowing. Independent correctness, de-slop, and final repair reviews are complete with no open findings.

Risk: medium. This changes diff classification, with conservative fallback for unsupported shapes. No public API or dependency changes.

@codecov

codecov Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f7414c2) to head (ccf29e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #650   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          300       301    +1     
  Lines        38284     38373   +89     
=========================================
+ Hits         38284     38373   +89     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@daveshanley
daveshanley marked this pull request as ready for review October 6, 2026 13:08
@daveshanley
daveshanley merged commit bcdf6bc into main Oct 6, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant