Repository navigation
Conversation
jordens
force-pushed
the
pr/embassy-runner
branch
from
August 20, 2026 14:38
ad52943 to
8860708
Compare
Member
|
Apologies for the delay in looking at this. I'm not sure yet whether we are going to want this once the merger with ntpd-rs has gone through. This adds quite a bit of hardware-specific code that isn't really the core focus of the project, and we might just not have the bandwidth to do maintenance on this. |
Author
|
Sure. But note that this is very much not hardware specific. It supports all of the STM32 ETH hardware that has PTP (silicon v1 and v2) plus any other future implementation of that ptp-driver trait that may come up (there is the esp family that just needs some glue code). |
Keep the f64 clamp comparisons and invalid-bound checks, but use a static panic message so embedded consumers do not retain core float formatting solely for configuration errors. Cover saturation, infinities, NaN propagation, signed zero, and invalid bounds. Paired Stabilizer FLS builds save 15,360 flash bytes.
jordens
force-pushed
the
pr/embassy-runner
branch
from
October 8, 2026 18:14
c83e852 to
559c161
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a statime ordinary-clock runner for embassy plus an example.
This also keeps the library outside Statime's workspace and the STM32H743 application in
its own standalone workspace. That way (like for the statime-stm32 example) board dependencies, target configuration, linker script, lockfile, and crate patches are contained.
E.g. an ESP CPU implementing the embassy clock trait can directly use this runner.
Stacks on top of #871 and #872
Close #845
I know I'm targetting a potentially dead horse but it's the most convenient approach currently. Happy to retarget later to whatever shape ntpd-rs ultimately assumes.