Repository navigation
[BUGFIX] Show annotation markers when the Y-axis excludes zero - #838
Closed
ayush-that wants to merge 4 commits into
Closed
ayush-that wants to merge 4 commits into
ayush-that wants to merge 4 commits into
Conversation
Signed-off-by: ayush-that <ayush1337@hotmail.com>
Signed-off-by: ayush-that <ayush1337@hotmail.com>
shahrokni
self-requested a review
September 30, 2026 10:35
github-project-automation
Bot
moved this to Backlog
in Perses General Availability Improvements
Member
|
The PR is missing the handling of negative data. Someone else did a PR for fixing the same issue and is handling it, closing this PR in favor of:#855. Still thanks for the PR 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes perses/perses#4463.
Annotation markers use the data Y-axis, so they disappear when its range excludes zero. The chart now places annotation series on a hidden, fixed Y-axis, keeping the markers at the bottom of the plot without changing the data series axes.
Screenshots
Before
After
Checklist
UI Changes