Repository navigation
Conversation
Signed-off-by: colivi <charles.olivi@gmail.com>
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Export "transformRequiresEachSample" next to the transform kinds.
"PivotByLabel" is the only kind that needs one row per timestamp. Callers can ask the helper instead of naming that kind themselves.
This follows the review on perses/plugins#830: "table-data-utils" should stay generic, and the kind-specific fact belongs with the transform definition. The table plugin still decides when to keep every sample, because those samples are dropped before "transformData" runs. This change does not alter how transforms are applied.
The plugin keeps a local copy of the set until this export is in a published "@perses-dev/components".
Checklist
[<catalog_entry>] <commit message>naming convention using one of thefollowing
catalog_entryvalues:FEATURE,ENHANCEMENT,BUGFIX,BREAKINGCHANGE,DOC,IGNORE.