Skip to content

fix: test results end-before - #288

Merged
cvvergara merged 1 commit into
pgRouting:developfrom
cvvergara:prepare-sdg3
Sep 22, 2026
Merged

cvvergara merged 1 commit into
pgRouting:developfrom
cvvergara:prepare-sdg3

Conversation

@cvvergara

@cvvergara cvvergara commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

small fix about limit of code on rst

@pgRouting/admins

Summary by CodeRabbit

  • Documentation
    • Updated the Exercise 8 documentation example for testing building_road. The displayed SQL script section now ends at the nearest_vertex.txt marker instead of the clean_buildings.txt marker. This changes which part of the script appears alongside the test output.

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c0c4290a-d8d7-487f-a3e6-795986f4bcef

📥 Commits

Reviewing files that changed from the base of the PR and between ace8c91 and 09ae6b0.

📒 Files selected for processing (1)
  • docs/un_sdg/sdg3-health.rst

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The Exercise 8 documentation now ends its sdg3.sql excerpt before the nearest_vertex.txt marker instead of the clean_buildings.txt marker.

Changes

Exercise 8 documentation

Layer / File(s) Summary
Update SQL excerpt marker
docs/un_sdg/sdg3-health.rst
The sdg3.sql literalinclude block now stops after the test_building_road section, before the clean_buildings section.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 09ae6

The documentation excerpt boundary matches the stated intent; no material merge risk is indicated.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title describes the change to where the documented test results end.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checked the excerpt with care,
The marker now stops it right there.
The road test appears,
Then the next section nears,
With tidy docs waiting to share.

Comment @coderabbitai help to get the list of available commands.

@cvvergara
cvvergara merged commit 750ff4d into pgRouting:develop Sep 22, 2026
3 checks passed
@cvvergara
cvvergara deleted the prepare-sdg3 branch September 23, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant