Conversation
peter279k
force-pushed
the
fix-grammars-ref-classobj-com-curl
branch
from
October 3, 2026 18:56
bbfc766 to
5be92e4
Compare
jordikroon
reviewed
Oct 4, 2026
|
|
||
| if(curl_error($ch)) { | ||
| // handle the error, or just | ||
| // handle the error, or just throw it |
Member
There was a problem hiding this comment.
Could you revert this? I don't see much value in this change.
Contributor
Author
There was a problem hiding this comment.
I think the "just" misses the verb. And the original sentence is not completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed log