ext/session: Remove redundant parentheses in session tests - #23609
Open
kamil-tekiela wants to merge 1 commit into
Open
ext/session: Remove redundant parentheses in session tests#23609kamil-tekiela wants to merge 1 commit into
kamil-tekiela wants to merge 1 commit into
Conversation
kamil-tekiela
force-pushed
the
Remove-redundant-parentheses-in-session
branch
from
September 7, 2026 17:48
8828c63 to
e7b867b
Compare
Member
Author
|
Dropped session_id_error3.phpt from the PR because my editor kept changing the invisible characters and I can't be bothered fighting it. |
Contributor
|
I am not sure I understand the purpose. What does it improve? |
Member
Author
Users tend to get confused when faced with unnecessary parentheses, e.g. when concatenation is involved. Since these lines are not part of the tests but of the SKIPIF, we don't need to be concerned about this breaking the tests. It's just a stylistic change to make it easier for users to visually parse the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.