Repository navigation
Harden Web Push configuration and subscription handling - #147
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
============================================
- Coverage 98.48% 98.22% -0.26%
- Complexity 249 276 +27
============================================
Files 9 11 +2
Lines 727 790 +63
============================================
+ Hits 716 776 +60
- Misses 11 14 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
subs subs Subs subs
rxu
reviewed
Oct 17, 2026
rxu
left a comment
Contributor
There was a problem hiding this comment.
Also (probably unrelated to this PR though), "Notification reminder pop-ups" button works regardless of web push notifications are enabled or not, so you can enable reminder anyway. If webpush notifications got disabled, it seems that reminder button makes no sense.
Co-authored-by: rxu <rxu@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens Web Push configuration, subscription storage, and notification delivery against malformed or unexpected input.
<head>into body output.