Implement Custom Error Pages

that will be used instead of nginx default error pages:
https://www.phpmyadmin.net/static/A

Note: The custom error page is already there, it just needs to be used for static files as well.

It's already handling, just throwing an error for some reason:

Line 41 in 35a9f3f

handler404 = 'pmaweb.views.notfound'

Lines 86 to 92 in 35a9f3f

    
           def notfound(request): 
        
               return render( 
        
                   request, 
        
                   '404.html', 
        
                   {'title': 'Page Not Found'}, 
        
                   status=404 
        
               )

Trying to fix on my PR, but since I never had worked with Python for web before, I may not fix it.

Yep, I read all the issues.

@nijel

@nijel @williamdes Can I work on this, if its still required?

@nijel

@nijel @williamdes Can I work on this, if its still required?

Sure, do you know enough python to finish #136?

@williamdes

@williamdes Thank you and yes I can try #136 .

@williamdes

@williamdes can you please confirm/share what the production settings.py looks like?

the path will be: phpmyadmin-website\pmaweb\settings.py

Important changes in the settings.py which is also in PR

DEBUG = FALSE
COMPRESS_ENABLED = os.environ.get('COMPRESS_ENABLED', False)

Fix phpmyadmin#30: Implement Custom Error Pages

Navigation Menu

Repository navigation

Implement Custom Error Pages #30

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	def notfound(request):
	return render(
	request,
	'404.html',
	{'title': 'Page Not Found'},
	status=404
	)

Implement Custom Error Pages #30

Description

Activity

AdrianoCahete commented on Nov 3, 2020

vimalMK commented on Nov 2, 2022

williamdes commented on Nov 2, 2022

vimalMK commented on Nov 2, 2022

vimalMK commented on Nov 3, 2022

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions