Skip to content

assertTrue seems to lose inferred type #229

Description

@eliashaeussler
  • phpstan/phpstan v2.1.13
  • phpstan/phpstan-phpunit v2.0.6

Given the following trait:

trait MockServerTrait
{
    private static ?MockWebServer\MockWebServer $mockServer = null;

    protected static function startMockServer(
        string $host = '127.0.0.1',
        int $port = 2083,
    ): MockWebServer\MockWebServer {
        self::$mockServer?->stop();
        self::$mockServer = new MockWebServer\MockWebServer($port, $host);
        self::$mockServer->start();

        \PHPStan\dumpType(self::$mockServer); // line 55
        self::assertTrue(self::$mockServer->isRunning());
        \PHPStan\dumpType(self::$mockServer); // line 57

        return self::$mockServer; // line 59
    }
}

When running PHPStan, I get the following errors:

------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/MockServerTrait.php (in context of class EliasHaeussler\CpanelRequests\Tests\MockServerAwareTestCase)                                                                                  
 ------ --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 
  55     Dumped type: donatj\MockWebServer\MockWebServer                                                                                                                                              
         ✏️  tests/MockServerTrait.php:55                                                                                                                                                             
  57     Dumped type: donatj\MockWebServer\MockWebServer|null                                                                                                                                         
         ✏️  tests/MockServerTrait.php:57                                                                                                                                                             
  59     Method EliasHaeussler\CpanelRequests\Tests\MockServerAwareTestCase::startMockServer() should return donatj\MockWebServer\MockWebServer but returns donatj\MockWebServer\MockWebServer|null.  
         🪪  return.type                                                                                                                                                                              
         ✏️  tests/MockServerTrait.php:59                                                                                                                                                             
 ------ ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

When I omit the last self::assertTrue, no errors are reported anymore.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions