Repository navigation
fix(server): avoid loading v2 transcripts for checkpoint effects - #12339
Open
juliusmarminge wants to merge 1 commit into
Open
juliusmarminge wants to merge 1 commit into
juliusmarminge wants to merge 1 commit into
Conversation
Contributor
Thread transfer impact
This comment will update automatically after the next completed run. |
juliusmarminge
force-pushed
the
checkpoint-v2/targeted-reads
branch
from
September 18, 2026 00:41
6974410 to
f1547a7
Compare
This comment has been minimized.
This comment has been minimized.
juliusmarminge
added this pull request to stack #12340
September 18, 2026 00:41
juliusmarminge
force-pushed
the
checkpoint-v2/targeted-reads
branch
from
September 18, 2026 00:44
f1547a7 to
ab03d21
Compare
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The PR substantially replaces full transcript projection reads with new target-specific SQLite and in-memory selection logic across checkpoint capture, rollback, and finalization. Although the scope and tests are focused, these critical runtime and persistence-path changes merit human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
force-pushed
the
checkpoint-v2/targeted-reads
branch
from
September 18, 2026 00:56
ab03d21 to
05ed3bf
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V2 checkpoint capture and rollback loaded the full thread projection, including conversation history and fork ancestry. Long conversations unnecessarily allocated and decoded large transcript payloads, and obsolete unrelated history could prevent checkpointing.
Add transactional reads for the exact checkpoint targets and switch capture/rollback to them. Finalization also uses checkpoint metadata for its workspace refresh instead of reloading the conversation after capture. Capture reads only its run, root node, scope, provider thread, and baseline readiness columns. Rollback retains the target attempt/provider turns, completed later runs/root nodes, bound session, and ready later checkpoints needed for existing rollback behavior. The in-memory store follows the same target selection.
Depends on #12338 and targets v2 from #2829.
Verification: two capture cases fail on the old full-read path and pass with these reads, while preserving concurrent delegated completion and at-least-once idempotency. SQLite/memory parity tests cover target selection, stale checkpoint scope/status filtering, and cross-thread ownership. An actual SQLite regression ignores obsolete transcript, unrelated run, and checkpoint file payloads. The seven focused projection/checkpoint/provider-control/finalization suites pass (52 tests). Server typecheck and focused lint pass.
A synthetic SQLite conversation with 200 × 128 KiB assistant items (25 MiB) measured these median read times over ten warmed reads on Node 24:
This measures database projection work only, not Git capture/restore latency. No timing thresholds were added to tests. Backend-only change; no visual evidence applies.
Prepared with Codex.