Repository navigation
feat(files): preview Word documents and Excel workbooks - #19114
Closed
piotrnowakowski wants to merge 5 commits into
Closed
piotrnowakowski wants to merge 5 commits into
piotrnowakowski wants to merge 5 commits into
Conversation
Office preview validation trusted ZIP metadata, repeated workspace updates reparsed unchanged files, and closing Word previews left queued rendering work. Validate actual archive expansion in a cancellable worker, bound and cancel Word phases, refresh by file identity, stream remote saves, and route mobile workspace Office files to the native viewer fallback. Keep spreadsheet payload and full-workbook parsing changes deferred for separate approval. Focused validation passed 167 tests across 12 files, scoped checks, and a production web build; browser fixtures and resource measurements are recorded in the PR evidence. Model: GPT-6.1-Sol. Harness: Codex desktop.
Excel previews retained every worksheet and could transfer 50 million characters into 25,000 table cells. Read workbook metadata first, inflate only the selected worksheet and required strings/styles, and bound the cell slice before SheetJS materializes it. Preserve sparse C9000 coordinates and formatting, cap retained/serialized text, and send 100-row pages from one selected-sheet cache. Coalesce obsolete sheet requests, terminate stalled workers, and guard formatting amplification. Focused validation passed 185 tests across 14 files and scoped checks; production-app pagination, source coordinates, switching, cleanup, and resource samples are recorded in the PR evidence. Model: GPT-6.1-Sol. Harness: Codex desktop.
Collaborator
|
Note Written by Thanks for proposing Word and Excel previews. This exceeds our current 500-changed-line intake limit for unvouched contributors, with new renderers, archive workers, dependencies, and mobile viewer support across 44 files. As Read this first explains, review capacity is limited, and right now we are only taking focused bug fixes from outside contributors. Please bring the proposal to an Ideas discussion and agree on a smaller approved scope before requesting reconsideration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read-only Word (.docx) and Excel (.xlsx) previews are available from Files, chat file links, and attachments beside the conversation.
Preview behavior
Resource management
Verification
Scope and limits
This draft provides read-only previews. Document editing, Excel charts and workbook styling, and formula recalculation are outside its scope. Documents exceeding preview budgets offer the original file for opening in another app.
Large worksheet XML and shared-string parts require bounded scans. Word DOM work runs on the main thread, with complexity limits and cancellation between rendering phases.
Runtime verification covers the local production web build. Native lifecycle tests pass, but live Android verification is blocked by Windows native dependency/build issues. Native-device behavior, Electron-specific downloads/performance, and relay/tunnel modes are unverified.
Evidence
Pagination and sheet-selection recording · Chat preview recording
Model: GPT-6.1-Sol. Harness: Codex desktop.