Repository navigation
Conversation
A live kiro-cli 2.31.0 session advertises effort for claude-fable-5.1 (low-max, default high) and kimi-k3 (low/high/max, default max), which KIRO_MODEL_EFFORT lacked, so the picker showed no Reasoning option and the server rejected a reasoningEffort for them. Co-Authored-By: Claude Opus 5.5 (Claude Code) <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The production provider now exposes reasoning controls for two models and establishes high/max as their default selections, changing product-facing defaults. The implementation is small and tested, but that default change warrants human review. You can add or adjust custom eligibility rules. Learn more. |
|
Note Written by Thanks for this. I'm closing it as part of PR triage. Right now we're only taking focused bug fixes from outside contributors (see Read this first), and this PR is not one. From the review: This adds Fable 5.1 and Kimi K3 reasoning options to the Kiro integration, which is absent from main. Model support additions need prior maintainer agreement. If you think this was a mistake, message me on Twitter at @maria_rcks and I'll take another look. |
Problem
On #14693,
claude-fable-5.1has no Reasoning option in the Kiro model picker, and the server rejects areasoningEffortfor it (reported in #14693 (comment) by @ash663).kimi-k3has the same gap. Both are missing fromKIRO_MODEL_EFFORT.Change
Adds both models to
KIRO_MODEL_EFFORTwith the levels a live Kiro session advertises for them:claude-fable-5.1: low, medium, high, xhigh, max (default high)kimi-k3: low, high, max (default max)The effort test now covers both.
Scope and approval
This targets
v2/kiro-acp(#14693), notmain. It fills in that PR's existing effort table, so it adds no new capability.Verification
kiro-cli acp --agent-engine=v3 --auth-method=clisession on kiro-cli 2.31.0 with no prompt and read themodeloption's_meta.kiro.effortLevels/defaultEffortLevel. Every model already in the table matches what Kiro advertises. Only these two were missing.vp test run src/provider/KiroProvider.test.ts: 9 passed.Written by Claude Opus 5.5 in Claude Code (via T3 Code).