Fix Flaky Tests - #4041
Open
brandonschabell wants to merge 1 commit into
Open
Fix Flaky Tests#4041brandonschabell wants to merge 1 commit into
brandonschabell wants to merge 1 commit into
Conversation
|
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The regression test can pass without exercising the debounce race, and the changelog omits the user-facing fix.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Stabilizes flaky integration tests, fixes debounced number-input stepper behavior, and improves benchmark reporting.
Changes:
- Replaces timing sleeps and immediate assertions with condition-based waits.
- Fixes
dcc.Inputstepper updates during debounce and adds regression coverage. - Publishes benchmark results through job summaries, including fork PRs.
| File | Description |
|---|---|
tests/websocket/test_ws_stream.py |
Synchronizes streamed frame assertions. |
tests/websocket/test_ws_get_prop.py |
Waits for the target element. |
tests/streaming/test_stream_callbacks_integration.py |
Synchronizes progressive rendering. |
tests/integration/test_csp.py |
Waits for callback output. |
tests/integration/renderer/test_dependencies.py |
Replaces retries with explicit waits. |
tests/integration/devtools/test_callback_validation.py |
Waits for visible error titles. |
tests/integration/callbacks/test_basic_callback.py |
Synchronizes callbacks per keystroke. |
tests/conftest.py |
Delays forced exit until pytest teardown. |
tests/background_callback/test_basic_long_callback008.py |
Avoids problematic disk-cache locking. |
components/dash-table/tests/selenium/test_pagination.py |
Waits for pagination state. |
components/dash-core-components/tests/integration/store/test_component_props.py |
Uses timestamp bounds instead of tolerance. |
components/dash-core-components/tests/integration/input/test_number_input.py |
Adds debounce-stepper regression coverage. |
components/dash-core-components/tests/integration/dropdown/test_dropdown_search_order.py |
Synchronizes dropdown focus and filtering. |
components/dash-core-components/tests/integration/dropdown/test_a11y.py |
Replaces retries with focus-aware waits. |
components/dash-core-components/src/components/Input.tsx |
Prevents stale debounced stepper updates. |
CHANGELOG.md |
Records test stabilization. |
.github/workflows/benchmarks.yml |
Writes benchmark results to job summaries. |
.ai/PERFORMANCE.md |
Documents benchmark reporting behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+299
to
+303
| for _ in range(5): | ||
| increment_btn.click() | ||
| dash_dcc.wait_for_text_to_equal("#div-fast", "103") | ||
| decrement_btn.click() | ||
| dash_dcc.wait_for_text_to_equal("#div-fast", "100") |
| - [#3986](https://github.com/plotly/dash/pull/3986) Adjust `_run_before_hooks` in the `fastapi` backend to honor a response returned by a `before_request` function, matching the `flask` backend's behavior. | ||
|
|
||
| ### Fixed | ||
| - [#4041](https://github.com/plotly/dash/pull/4041) Fix flaky integration tests by replacing fixed sleeps and immediate asserts with waits, and remove their `@flaky` retry markers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix flaky tests. Fix issue with input reverting to previous value during debounce
Contributor Checklist
optionals
CHANGELOG.md