Repository navigation
feat(options): infer bracket access types for Options offsets - #27
Merged
Merged
Conversation
Unify option key typing in OptionTypes and add an expression resolver so
$options['key'] matches $options->get('key') when the offset is a constant.
Add registry sync tests, POLYLANG_PRO_PHPSTAN constant coverage, edge-case assertions, README guidance, and fix the polylang scan path for local dev.
Screenfeed
requested changes
Oct 16, 2026
The OptionTypes refactor dropped the non-empty-array intersection that existed before; restore it so the inferred type matches the real shape.
Avoid resolving constant string types twice when inferring Options offset and method return types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add PHPStan inference for
$options['key']so bracket access matches->get('key')for constant option keys onWP_Syntex\Polylang\Options\Options.Why?
Polylang 3.7+ uses array syntax extensively (
$options['version'],$this->options['default_lang']), but PHPStan resolves bracket access viaArrayAccess<non-falsy-string, mixed>, which forcesmixedand dozens of inline@phpstan-varannotations in application code.How?
OptionTypesas a single key → PHPStan type map (free + Pro keys).OptionsGetDynamicMethodReturnTypeExtensionto delegate toOptionTypes.OptionsOffsetExpressionTypeResolverExtensionforArrayDimFetchonOptions.Optionssource (scanDirectories) plus Pro coverage via DI (proEnabled: true).Test plan
composer testin polylang-phpstan (48 tests)composer stanin polylang with synced extension (no errors on$this->options['default_lang'])