Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parsing
[x="\000061 b"]currently produces the attribute valuea binstead ofab. Changing the node's quote mark then serializes a selector matching a different value.Consume the optional CSS whitespace after the hexadecimal digits, including after a six-digit escape. Handle CRLF as one newline and preserve the original raw selector. Add public parser regressions for each whitespace form, replacement characters, and boundaries that must stay in the value.
Validation: 15 regression cases fail before the fix.
npm testpasses lint, types, coverage thresholds, and all 834 tests on Node 24 and 26. The existing 30 unescape tests also pass; 48 original/reserialized selector pairs match the expected attribute in Chrome. Changed-file formatting passes; the full formatting check flags only unchangedsrc/__tests__/exceptions.mjs.