Repository navigation
chore(cli): remove the engine 0.6.2 conformance exceptions - #328
Conversation
@prisma/orm-toolchain 8.0.0-rc.14 peers @prisma/cli-engine 0.6.2, and the CLI now pins that release, so the check no longer needs to allow the mismatch for it. The composer-cli exception stays until Composer releases against 0.6.2. Refs #314 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. Summary by CodeRabbit
WalkthroughThe tarball conformance check no longer includes the exception for Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to This tightens an internal conformance check by removing an exception that is no longer needed. It does not change runtime behavior and has no known merge risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
commit: |
…ne-exception Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
packages/cli/scripts/conformance.tslisted two packages that were allowed to peer an older@prisma/cli-enginethan the oneprismaships. This pull request empties that list:Why now
#313 shipped engine 0.6.2 while
@prisma/composer-cliand@prisma/orm-toolchainstill peered 0.6.1, so it added two entries to let the conformance check pass. Both packages have since released against 0.6.2 and the CLI pins those releases:@prisma/orm-toolchain8.0.0-rc.14, pinned by Follow the products' released versions: @prisma/orm-toolchain 8.0.0-rc.13 -> 8.0.0-rc.14 #327.@prisma/composer-cli0.26.0, pinned by The host runs Composer 0.26.0: one config file, no prisma-composer binary (8.0.0-rc.20) #330. That pull request already removed the Composer entry onmain.With both pins in place the check finds no mismatch, so the remaining entry does nothing. Leaving it would let a real 0.6.1 and 0.6.2 mismatch through if those versions ever met again.
Verification
I ran the conformance check locally on both channels at the merge commit, the way
.github/workflows/publish.ymlruns it.5 subject(s) checked, nothing to report.update-product-versions.mjs --channel dev, lockfile refreshed, rebuilt,PUBLISH_CHANNEL=dev):5 subject(s) checked, nothing to report.Closes #314
Agent: pythagoras-29
🤖 Generated with Claude Code