Skip to content

chore(cli): remove the engine 0.6.2 conformance exceptions - #328

Merged
wmadden-electric merged 2 commits into
mainfrom
chore/remove-orm-engine-exception
Oct 5, 2026
Merged

wmadden-electric merged 2 commits into
mainfrom
chore/remove-orm-engine-exception

Conversation

@wmadden-electric

@wmadden-electric wmadden-electric commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

packages/cli/scripts/conformance.ts listed two packages that were allowed to peer an older @prisma/cli-engine than the one prisma ships. This pull request empties that list:

       familyPackages: ["@prisma/composer-cli", "@prisma/orm-toolchain"],
-      exceptions: [
-        {
-          familyPackage: "@prisma/orm-toolchain",
-          familyPin: "0.6.1",
-          shellPin: "0.6.2",
-          ...
-        },
-      ],
+      exceptions: [],

Why now

#313 shipped engine 0.6.2 while @prisma/composer-cli and @prisma/orm-toolchain still peered 0.6.1, so it added two entries to let the conformance check pass. Both packages have since released against 0.6.2 and the CLI pins those releases:

With both pins in place the check finds no mismatch, so the remaining entry does nothing. Leaving it would let a real 0.6.1 and 0.6.2 mismatch through if those versions ever met again.

Verification

I ran the conformance check locally on both channels at the merge commit, the way .github/workflows/publish.yml runs it.

  • Release channel: 5 subject(s) checked, nothing to report.
  • Development channel (dev version stamped, update-product-versions.mjs --channel dev, lockfile refreshed, rebuilt, PUBLISH_CHANNEL=dev): 5 subject(s) checked, nothing to report.

Closes #314

Agent: pythagoras-29

🤖 Generated with Claude Code

@prisma/orm-toolchain 8.0.0-rc.14 peers @prisma/cli-engine 0.6.2, and the CLI now pins that release, so the check no longer needs to allow the mismatch for it. The composer-cli exception stays until Composer releases against 0.6.2.

Refs #314

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0f1b761b-0c0a-4b5c-9762-7fb044bc503c

📥 Commits

Reviewing files that changed from the base of the PR and between 874b6e6 and 18393db.

📒 Files selected for processing (1)
  • packages/cli/scripts/conformance.ts
💤 Files with no reviewable changes (1)
  • packages/cli/scripts/conformance.ts

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Summary by CodeRabbit

  • Chores
    • Removed the special-case allowance for mismatched toolchain and shell version pins in the tarball conformance check.

Walkthrough

The tarball conformance check no longer includes the exception for @prisma/orm-toolchain pin 0.6.1 with shell pin 0.6.2. The @prisma/composer-cli exception remains.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 18393

This tightens an internal conformance check by removing an exception that is no longer needed. It does not change runtime behavior and has no known merge risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title identifies the removal of the CLI engine conformance exception, which is the main change. The plural wording may imply that all exceptions were removed, but the title remains clearly related…
Description check ✅ Passed The description explains the exception removal, why it is no longer needed, and the conformance-check verification. It is directly related to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@328
npx https://pkg.pr.new/@prisma/cli-engine@328

commit: 87f7448

…ne-exception

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@wmadden-electric wmadden-electric changed the title chore(cli): remove the orm-toolchain engine 0.6.2 conformance exception chore(cli): remove the engine 0.6.2 conformance exceptions Oct 5, 2026
@wmadden-electric
wmadden-electric merged commit 471474a into main Oct 5, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove the engine 0.6.2 conformance exceptions once both families peer 0.6.2

2 participants