Repository navigation
dev2-site: healthchecks for every app + redis container, and nginx->app keepalive - #153
Merged
Merged
Conversation
…ealthcheck watchdog-autoheal restarts what Docker marked unhealthy, but 47 of 230 containers on dev2 had no healthcheck, so a wedged one stayed invisible. The probe runs inside the container with the runtime it already has (bun or node) and passes on any HTTP status under 500 without following redirects, so a blocked event loop fails and a 404 or a login redirect does not. Redis gets redis-cli ping. The chosen test is kept in the site state and render_compose writes it back, so provision cannot drop it; the migrate sequence runs it after deploy. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ever report an empty read as fine Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… connections healthchecks: the container reports the healthcheck we added, which read as 'already has one', so the plan was empty and health_compose removed our marked block (hqtui.com lost its check on the first fleet run). A marked block is ours and is re-planned. vhost: every plain proxy_pass to a loopback port becomes an upstream with keepalive 16 and keepalive_timeout 4s (under Node's 5s server timeout, so nginx never reuses a socket the app just closed), and Connection comes from a new $connection_upgrade_keepalive map (installed to conf.d by the tool) that still upgrades websockets but no longer sends close on every request. Before this nginx opened a new TCP connection per request. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan32 finding(s) HIGH/CRITICAL: 7 | MEDIUM: 12 | LOW: 13
Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
healthchecks (
dev2-site healthchecks <site>… | --all): watchdog-autoheal restarts what Docker marked unhealthy, but 47 of 230 dev2 containers had no healthcheck.redis-cli ping.render_composewrites it back, andmigrateruns the step afterdeploy.vhost keepalive:
proxy_passbecomes anupstreamwithkeepalive 16; keepalive_timeout 4s. That's under Node's 5s server keepAliveTimeout, so nginx never reuses a socket the app just closed.$connection_upgrade_keepalivemap (installed to conf.d by the tool) still upgrades websockets but no longer sendsclose.vhost --all --dry-runover 78 sites showed only keepalive diffs.🤖 Generated with Claude Code