Repository navigation
desktop smoke: poll for the selection test (0.3.2) - #10
Merged
Merged
Conversation
….3.2) The v0.3.1 release smoke (8 s, slower runner) checked before the split pane's shell had run printf: 'mouse mode none'. Inject DECSET 1003 straight into the focused pane's terminal, poll until it is on, and make the final check wait for the result. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.3.1 release smoke failed with
selection: mouse mode none, not any. On the slower x86_64 release runner, with an 8 s wait, the test checked before the split pane's shell had run theprintfthat enables mouse tracking.Now the test writes DECSET 1003 straight into the focused pane's terminal over
pty:data, so there is no shell to wait for. It polls until tracking isanyand the final check waits for the result. The version is bumped to 0.3.2, because tag v0.3.1 already points at the commit whose release failed.🤖 Generated with Claude Code