Repository navigation
fix(invite-only): show the site nav on the invite-only screen - #272
Merged
Merged
Conversation
The page rendered bare (logo + text), so visitors landing there had no sidebar or header and no way to tell where they were. Wrap it in MainLayout like /login and /signup; MainLayout already renders the site footer with the ring links, so the layout no longer adds its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ThreatCrush Security Scan95 finding(s) HIGH/CRITICAL: 11 | MEDIUM: 29 | LOW: 55
…and 45 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users landing on https://bittorrented.com/invite-only were confused: the page had no sidebar or header.
/invite-onlyinMainLayout(same as/login,/signup), so it gets the sidebar + header.SiteFooter:MainLayoutalready renders it (server-rendered, ring links intact; verified one<footer>in the SSR HTML).Nav links still 307 back to
/invite-onlyfor non-admins while the site is invite only; that's the existing gate.Checked:
tscclean, invites/layout tests pass, dev server SSR of /invite-only contains<aside>,<header>, nav links and one footer.🤖 Generated with Claude Code