Conversation
jack-berg
requested review from
dhoard,
fstab,
jaydeluca and
zeitlinger
as code owners
September 11, 2026 22:14
jack-berg
changed the title
Contributor
Benchmark resultsBenchmark run succeeded for
Prometheus Java Client BenchmarksRun Information
Comparison with base
Results for PR headCounterBenchmark
HistogramBenchmark
HistogramTextFormatBenchmark
TextFormatUtilBenchmark
New benchmarks in PR headThese benchmarks have no base counterpart; scores are descriptive only and have no regression verdict.
Raw ResultsNotes
Benchmark Descriptions
|
Member
|
@jack-berg your commits and not signed |
jack-berg
force-pushed
the
update-otel-benchmarks
branch
from
September 16, 2026 20:14
6de043a to
b40b06d
Compare
Signed-off-by: Jack Berg <34418638+jack-berg@users.noreply.github.com>
… update-otel-benchmarks
jack-berg
force-pushed
the
update-otel-benchmarks
branch
from
September 16, 2026 20:15
b40b06d to
0ef812b
Compare
Member
|
Could we use the same attribute workload for the bound and unbound histogram scenarios? Currently the bound cases bind path/status, while the unbound cases record without attributes, so the comparison changes both binding and workload. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating benchmarks after substantial efforts to improve otel performance under contention. Changes:
Benchmark results on my machine:
The improvements to otel explicit histogram performance came from a design inspired by prometheus client_java. The code contains attribution. I did manage to slightly improve on the design - If you agree, I'm happy to chat about it and encourage prom client_java to copy any of the bits you think are helpful.