Skip to content

feat: Add a type alias for PspIoDrv to improve compatibility - #397

Merged
TheMrIron2 merged 2 commits into
masterfrom
grayjack-m33-compat
Oct 15, 2026
Merged

TheMrIron2 merged 2 commits into
masterfrom
grayjack-m33-compat

Conversation

@GrayJack

@GrayJack GrayJack commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Not much to add, just that it will make easier to make old homebrew/cfw to compile on modern SDK

Best reviewed per commit

@TheMrIron2

TheMrIron2 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The change itself seems fine. This isn't a blocking question, but I'm wondering what the purpose of the second commit is. The feat commit 6482a98 seems to implement the change itself, the second 214358d chore: Clean up just changes 18 whitespaces.

It might be better for hygiene overall to just add the first commit and drop the second.

@GrayJack

GrayJack commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor Author

but I'm wondering what the purpose of the second commit is

Clean up the header file, we have a bunch of files with inconsistent line endings. Since I got no answers when I brought up the subject of automated formating C code; and had no time to bring the subject again, what I'm doing is at least making line ends consistent every file I have to touch (adding this as a second commit).

It might be better for hygiene overall to just add the first commit and drop the second.

It is kinda ok on rebase-based and commit-based merge, as the commit history are kept intact. But I agree it is not hygenic on squash-based merges.

@TheMrIron2

TheMrIron2 commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

That's fair enough. I think if we rebase the hygiene concern is answered. Thanks for following up.

@TheMrIron2
TheMrIron2 merged commit 9356a64 into master Oct 15, 2026
2 checks passed
@sharkwouter
sharkwouter deleted the grayjack-m33-compat branch October 15, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants