Repository navigation
feat: Add a type alias for PspIoDrv to improve compatibility - #397
Conversation
|
The change itself seems fine. This isn't a blocking question, but I'm wondering what the purpose of the second commit is. The It might be better for hygiene overall to just add the first commit and drop the second. |
Clean up the header file, we have a bunch of files with inconsistent line endings. Since I got no answers when I brought up the subject of automated formating C code; and had no time to bring the subject again, what I'm doing is at least making line ends consistent every file I have to touch (adding this as a second commit).
It is kinda ok on rebase-based and commit-based merge, as the commit history are kept intact. But I agree it is not hygenic on squash-based merges. |
|
That's fair enough. I think if we rebase the hygiene concern is answered. Thanks for following up. |
Not much to add, just that it will make easier to make old homebrew/cfw to compile on modern SDK
Best reviewed per commit