Skip to content

Bound the sensor list start index and its paging reserve (iteration branch) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ptr727 wants to merge 8 commits into
base: dev
Choose a base branch
from
Open

Bound the sensor list start index and its paging reserve (iteration branch) #8

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb9dfb8
fix: bound the `sensor list` start index and its paging reserve
ptr727 Sep 17, 2026
b61a369
fix: keep the continuation marker intact when a row has to be truncated
ptr727 Sep 17, 2026
a5a2165
docs: say newline rather than CR in the row-terminator comment
ptr727 Sep 17, 2026
c5b60c0
fix: clamp the paging start while parsing, not after
ptr727 Sep 17, 2026
3c9df06
docs: do not imply the vars header is always present
ptr727 Sep 17, 2026
134edc2
fix: bound the reply against the prefixed buffer, not the raw one
ptr727 Sep 17, 2026
ea3acfb
Merge remote-tracking branch 'origin/dev' into work/sensor-list-paging
ptr727 Oct 5, 2026
ec05125
fix: cut `sensor list` down to a negative-start guard
ptr727 Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/helpers/CommonCLI.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ void CommonCLI::handleCommand(uint32_t sender_timestamp, char* command, char* re
if (strlen(command) > 11) {
start = _atoi(command+12);
}
if (start >= end) {
if (start < 0 || start >= end) { // _atoi() is unsigned: a start of 2^31 or more wraps negative
strcpy(reply, "no custom var");
} else {
sprintf(dp, "%d vars\n", end);
Expand Down