Add EnvVarHeaderContentGuard - #8015
Merged
Merged
Conversation
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
2 times, most recently
from
August 27, 2026 18:13
a8e4cc9 to
6d4e26f
Compare
github-actions
Bot
added
multi-commit
no-changelog
no-issue
and removed
multi-commit
no-issue
no-changelog
labels
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
from
August 27, 2026 21:52
6421c14 to
adef173
Compare
github-actions
Bot
added
multi-commit
no-changelog
no-issue
and removed
multi-commit
no-issue
no-changelog
labels
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
from
August 31, 2026 20:06
a92a9c1 to
783cbba
Compare
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
from
September 4, 2026 13:21
783cbba to
1cc0b2d
Compare
ggainey
requested changes
Sep 21, 2026
| component_version: "${COMPONENT_VERSION}" | ||
| pulp_env: {"PULP_CA_BUNDLE": "/etc/pulp/certs/pulp_webserver.crt"} | ||
| pulp_settings: {"allowed_export_paths": ["/tmp"], "allowed_import_paths": ["/tmp"], "api_root": "/pulp/", "content_path_prefix": "/somewhere/else/", "csrf_trusted_origins": ["https://pulp:443"], "distributed_publication_retention_period": 3, "orphan_protection_time": 0, "task_diagnostics": ["memory"], "task_protection_time": 10, "tmpfile_protection_time": 10, "upload_protection_time": 10} | ||
| pulp_env: {"ENVVAR_HEADER_GUARD_TEST_SECRET": "functional-test-secret-value", "PULP_CA_BUNDLE": "/etc/pulp/certs/pulp_webserver.crt"} |
Contributor
There was a problem hiding this comment.
the next plugin-template run will throw this away. Also - static secrets, even test ones, make gitleaks yell at us. Let's generate a random one "on the fly", something like this:
Once we like it here, let's get this into plugin_template instead.
Member
Author
There was a problem hiding this comment.
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
from
September 22, 2026 11:46
807bd9e to
14d2a08
Compare
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
2 times, most recently
from
September 22, 2026 12:12
14ebdef to
6ae3d7a
Compare
Validate a Base64-encoded request header against a content-app environment variable so shared secrets can rotate without updating guard records. Names must be listed in ENVVAR_HEADER_CONTENT_GUARD_ALLOWED_VARS. fixes pulp#8007 Assisted-by: Cursor Grok 4.6
decko
force-pushed
the
pulp-2257-envvar-header-guard
branch
from
September 22, 2026 12:15
6ae3d7a to
ce811ce
Compare
ggainey
approved these changes
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvVarHeaderContentGuardso a Base64-encoded request header can be checked against a content-app environment variable (fixes #8007). Rotation is a deploy/env change, not a DB update ofHeaderContentGuard.header_value.env_varmust be listed inENVVAR_HEADER_CONTENT_GUARD_ALLOWED_VARS(default[]). The secret is never stored or returned by the API.ENVVAR_HEADER_GUARD_TEST_SECRETfrom the Pulp container env (injected viatemplate_config.yml/ CIpulp_env).Test plan
pytest -k envvar_headerunit tests (secret + allowlist set in the pulp container)pytest -k envvar_headerfunctional tests (create guard, 403 without/wrong header, 404 with matching Base64 header, 400 for disallowedenv_var, access policy present)/pulp/api/v3/contentguards/core/envvar_header/and that GET does not expose a secret valueRelated: PULP-2257, pulp-service prototype pulp/pulp-service#1420
Closes #8007
Assisted-by: Cursor Grok 4.6
Made with Cursor